linux-kernel - RE: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB6PR0402MB27604BD713C4A9EF197AB61788E90@DB6PR0402MB2760.eurprd04.prod.outlook.com>
Date:   Tue, 10 Nov 2020 05:25:35 +0000
From:   Peng Fan <peng.fan@....com>
To:     Rob Herring <robh@...nel.org>, Alice Guo <alice.guo@....com>
CC:     "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "krzk@...nel.org" <krzk@...nel.org>,
        dl-linux-imx <linux-imx@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc for
 soc unique ID

> Subject: Re: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc for
> soc unique ID
> 
> On Thu, Nov 05, 2020 at 03:26:26PM +0800, Alice Guo wrote:
> > Add DT Binding doc for the Unique ID of i.MX 8M series.
> >
> > Signed-off-by: Alice Guo <alice.guo@....com>
> > ---
> >  .../devicetree/bindings/arm/fsl.yaml          | 33
> +++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index e4db0f9ed664..0419f078502b 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -901,6 +901,39 @@ properties:
> >                - fsl,s32v234-evb           # S32V234-EVB2
> Customer Evaluation Board
> >            - const: fsl,s32v234
> >
> > +  soc:
> > +    description:
> > +      i.MX8M Family SoC must provide a soc node in the root of the
> device tree,
> > +      representing the System-on-Chip since these test chips are rather
> complex.
> > +    type: object
> > +    properties:
> > +      compatible:
> > +        oneOf:
> > +          - items:
> > +              - const: fsl,imx8mm-soc
> > +              - const: simple-bus
> > +          - items:
> > +              - const: fsl,imx8mn-soc
> > +              - const: simple-bus
> > +          - items:
> > +              - const: fsl,imx8mp-soc
> > +              - const: simple-bus
> > +          - items:
> > +              - const: fsl,imx8mq-soc
> > +              - const: simple-bus
> 
> items:
>   - enum:
>       - fsl,imx8mm-soc
>       - fsl,imx8mn-soc
>       - fsl,imx8mp-soc
>       - fsl,imx8mq-soc
>   - const: simple-bus
> 
> > +
> > +      nvmem-cells:
> > +        maxItems: 1
> > +        description: Phandle to the SOC Unique ID provided by a nvmem
> node
> > +
> > +      nvmem-cells-names:
> > +        const: soc_unique_id
> > +
> > +    required:
> > +      - compatible
> > +      - nvmem-cells
> > +      - nvmem-cell-names
> > +
> 
> 'soc' should be required?

The fsl,imx8m[m,n,p,q] already used by root node compatible.
So here could reuse the same compatible string? Or
We add an extra 'soc' here?

Thanks,
Peng. 

> 
> >  additionalProperties: true
> >
> >  ...
> > --
> > 2.17.1
> >