linux-kernel - Re: [PATCH 02/24] bpf: Add build_id_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201110100157.GA387652@krava>
Date:   Tue, 10 Nov 2020 11:01:57 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Song Liu <songliubraving@...com>,
        lkml <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Ingo Molnar <mingo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Michael Petlan <mpetlan@...hat.com>,
        Ian Rogers <irogers@...gle.com>,
        Stephane Eranian <eranian@...gle.com>,
        Alexey Budankov <alexey.budankov@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH 02/24] bpf: Add build_id_parse_size function

On Mon, Nov 09, 2020 at 04:15:42PM -0800, Alexei Starovoitov wrote:
> On Mon, Nov 9, 2020 at 1:54 PM Jiri Olsa <jolsa@...nel.org> wrote:
> >
> > It's possible to have other build id types (other than default
> > SHA1). Currently there's also ld support for MD5 build id.
> >
> > Adding build_id_parse_size function, that returns also size of
> > the parsed build id, so we can recognize the build id type.
> >
> > Cc: Alexei Starovoitov <ast@...nel.org>
> > Cc: Song Liu <songliubraving@...com>
> > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > ---
> >  include/linux/buildid.h |  2 ++
> >  lib/buildid.c           | 31 ++++++++++++++++++++++++-------
> >  2 files changed, 26 insertions(+), 7 deletions(-)
> >
> > diff --git a/include/linux/buildid.h b/include/linux/buildid.h
> > index 3be5b49719f1..edba89834b4c 100644
> > --- a/include/linux/buildid.h
> > +++ b/include/linux/buildid.h
> > @@ -7,5 +7,7 @@
> >  #define BUILD_ID_SIZE 20
> >
> >  int build_id_parse(struct vm_area_struct *vma, unsigned char *build_id);
> > +int build_id_parse_size(struct vm_area_struct *vma, unsigned char *build_id,
> > +                       __u32 *size);
> 
> I think it's too many choices for such trivial api.
> Just keep one build_id_parse() with two outputs
> and fix the callers.
> 

ok, will do

jirka