linux-kernel - Re: [PATCH] [v2] drm/omap: Fix runtime PM imbalance on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1457eb91-eefe-acd1-e605-5f018437fe70@ti.com>
Date:   Tue, 10 Nov 2020 14:54:06 +0200
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     Dinghao Liu <dinghao.liu@....edu.cn>, <kjlu@....edu>
CC:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Wambui Karuga <wambui.karugax@...il.com>,
        Tony Lindgren <tony@...mide.com>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        zhengbin <zhengbin13@...wei.com>, Jyri Sarha <jsarha@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sam Ravnborg <sam@...nborg.org>,
        YueHaibing <yuehaibing@...wei.com>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [v2] drm/omap: Fix runtime PM imbalance on error

On 22/08/2020 09:57, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter
> even when it returns an error code. However, users of its
> direct wrappers in omapdrm assume that PM usage counter will
> not change on error. Thus a pairing decrement is needed on
> the error handling path for these wrappers to keep the counter
> balanced.
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> ---
> 
> Changelog:
> 
> v2: - Fix 5 additional similar cases in omapdrm.

Thanks, I'll apply to drm-misc-next.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki