linux-kernel - Re: [PATCH] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOJe8K2tL5x-dESsV+PFq1Gii-yB=fJh7i-=E-FbrJeioo6pqA@mail.gmail.com>
Date:   Tue, 10 Nov 2020 16:02:27 +0300
From:   Denis Kirjanov <kda@...ux-powerpc.org>
To:     xiakaixu1987@...il.com
Cc:     ast@...nel.org, daniel@...earbox.net, kafai@...com,
        songliubraving@...com, yhs@...com, andrii@...nel.org,
        john.fastabend@...il.com, kpsingh@...omium.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org, Kaixu Xia <kaixuxia@...cent.com>
Subject: Re: [PATCH] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id

On 11/10/20, xiakaixu1987@...il.com <xiakaixu1987@...il.com> wrote:
> From: Kaixu Xia <kaixuxia@...cent.com>
>
> The unsigned variable datasec_id is assigned a return value from the call
> to check_pseudo_btf_id(), which may return negative error code.
>
> Fixes coccicheck warning:
>
> ./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expression compared
> with zero: datasec_id > 0
>
> Reported-by: Tosk Robot <tencent_os_robot@...cent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>
> ---
>  kernel/bpf/verifier.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 6200519582a6..e9d8d4309bb4 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -9572,7 +9572,7 @@ static int check_pseudo_btf_id(struct bpf_verifier_env
> *env,
>  			       struct bpf_insn *insn,
>  			       struct bpf_insn_aux_data *aux)
>  {
> -	u32 datasec_id, type, id = insn->imm;
> +	s32 datasec_id, type, id = insn->imm;

but the value is passed as u32 to btf_type_by_id()...

btf_find_by_name_kind() returns s32


>  	const struct btf_var_secinfo *vsi;
>  	const struct btf_type *datasec;
>  	const struct btf_type *t;
> --
> 2.20.0
>
>