linux-kernel - Re: [PATCH] printk: ringbuffer: Convert function argument to local variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e6c7fcaa-2a65-7586-d82a-450996986770@suse.com>
Date:   Tue, 10 Nov 2020 15:19:46 +0200
From:   Nikolay Borisov <nborisov@...e.com>
To:     John Ogness <john.ogness@...utronix.de>, pmladek@...e.com,
        sergey.senozhatsky@...il.com
Cc:     linux-kernel@...r.kernel.org, rostedt@...dmis.org
Subject: Re: [PATCH] printk: ringbuffer: Convert function argument to local
 variable



On 10.11.20 г. 15:14 ч., John Ogness wrote:
> On 2020-11-10, Nikolay Borisov <nborisov@...e.com> wrote:
>> data_alloc's 2nd argument is always rb::text_data_ring and that functino
>> always takes a struct printk_ringbuffer. Instead of passing the data
>> ring buffer as an argument simply make it a local variable.
> 
> This is a relic of when we had a second data ring (for
> dictionaries). The patch is a nice cleanup, but there are actually
> several functions that could use this exact same cleanup:
> 
> - data_make_reusable()
> - data_push_tail()
> - data_alloc()
> - data_realloc()
> 
> Perhaps we should fix them all in a single patch?

I observed that right after sending this patch, so I have authored the
necessary changes I can squash them and send them.

> 
> John Ogness
>