linux-kernel - Re: [PATCH] sched/fair: Remove the redundant critical section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Nov 2020 14:49:15 +0100
From:   Vincent Guittot <vincent.guittot@...aro.org>
To:     Qi Zheng <arch0.zheng@...il.com>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched/fair: Remove the redundant critical section

On Tue, 10 Nov 2020 at 14:41, Qi Zheng <arch0.zheng@...il.com> wrote:
>
> Now there is nothing in the critical section, so remove it.

https://lkml.org/lkml/2020/10/30/689

>
> Signed-off-by: Qi Zheng <arch0.zheng@...il.com>
> ---
>  kernel/sched/fair.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 52cacfc62922..06c4f3430e95 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5114,9 +5114,6 @@ static void do_sched_cfs_slack_timer(struct cfs_bandwidth *cfs_b)
>                 return;
>
>         distribute_cfs_runtime(cfs_b);
> -
> -       raw_spin_lock_irqsave(&cfs_b->lock, flags);
> -       raw_spin_unlock_irqrestore(&cfs_b->lock, flags);
>  }
>
>  /*
> --
> 2.25.1
>