linux-kernel - Re: [PATCH v1] spi: fix client driver breakages when using GPIO descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Nov 2020 11:24:14 -0500
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Jonathan Cameron <jonathan.cameron@...wei.com>,
        Lukas Wunner <lukas@...ner.de>,
        linux-spi <linux-spi@...r.kernel.org>,
        Simon Han <z.han@...bus.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>
Subject: Re: [PATCH v1] spi: fix client driver breakages when using GPIO descriptors

On Wed, Nov 11, 2020 at 10:48 AM Mark Brown <broonie@...nel.org> wrote:
>
> Applied to
>
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thank you !

Now that our minds are still focused on this subject, should
commit 138c9c32f090 ("spi: spidev: Fix CS polarity if GPIO descriptors
are used")
be reverted?

This fixed spidev to deal with SPI_CS_HIGH on gpiod.
But after our fix, its behaviour will probably be broken again.

Another candidate for revert is
commit ada9e3fcc175 ("spi: dw: Correct handling of native chipselect")
although I don't understand that code well enough to be sure.

Adding Charles Keepax.