linux-kernel - Re: [PATCH v6 11/11] mfd: mt6360: Remove MT6360 regulator of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Nov 2020 16:47:14 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Gene Chen <gene.chen.richtek@...il.com>
Cc:     sre@...nel.org, matthias.bgg@...il.com, robh+dt@...nel.org,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        gene_chen@...htek.com, Wilma.Wu@...iatek.com,
        shufan_lee@...htek.com, cy_huang@...htek.com,
        benjamin.chao@...iatek.com
Subject: Re: [PATCH v6 11/11] mfd: mt6360: Remove MT6360 regulator
 of_compatible attribute

On Fri, 06 Nov 2020, Gene Chen wrote:

> From: Gene Chen <gene_chen@...htek.com>
> 
> Remove MT6360 regulator of_compatible attribute because
> MFD device should just instantiate the platform device.
> 
> Signed-off-by: Gene Chen <gene_chen@...htek.com>
> ---
>  drivers/mfd/mt6360-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
> index 4bcfa7f..539ab43 100644
> --- a/drivers/mfd/mt6360-core.c
> +++ b/drivers/mfd/mt6360-core.c
> @@ -340,7 +340,7 @@ static const struct mfd_cell mt6360_devs[] = {
>  	OF_MFD_CELL("mt6360-led", mt6360_led_resources,
>  		    NULL, 0, 0, "mediatek,mt6360-led"),
>  	OF_MFD_CELL("mt6360-regulator", mt6360_regulator_resources,
> -		    NULL, 0, 0, "mediatek,mt6360-regulator"),
> +		    NULL, 0, 0, NULL),

If you're no longer providing an OF compatible, you should use one of
the simper helpers.

>  	OF_MFD_CELL("mt6360-tcpc", NULL,
>  		    NULL, 0, 0, "mediatek,mt6360-tcpc"),
>  };

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog