linux-kernel - Re: [PATCH 1/1] watchdog: wdat_wdt: Fix missing kerneldoc reported by W=1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Nov 2020 09:49:23 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     vee.khee.wong@...el.com, Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] watchdog: wdat_wdt: Fix missing kerneldoc reported by
 W=1

On 11/11/20 9:22 AM, vee.khee.wong@...el.com wrote:
> From: Wong Vee Khee <vee.khee.wong@...el.com>
> 
> Fix the following warning while compiling with W=1.
> 
> drivers/watchdog/wdat_wdt.c:48: warning: Function parameter or member 'instructions' not described in 'wdat_wdt'
> 
> Signed-off-by: Wong Vee Khee <vee.khee.wong@...el.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/wdat_wdt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/wdat_wdt.c b/drivers/watchdog/wdat_wdt.c
> index 3065dd670a18..cec7917790e5 100644
> --- a/drivers/watchdog/wdat_wdt.c
> +++ b/drivers/watchdog/wdat_wdt.c
> @@ -34,9 +34,9 @@ struct wdat_instruction {
>   * @period: How long is one watchdog period in ms
>   * @stopped_in_sleep: Is this watchdog stopped by the firmware in S1-S5
>   * @stopped: Was the watchdog stopped by the driver in suspend
> - * @actions: An array of instruction lists indexed by an action number from
> - *           the WDAT table. There can be %NULL entries for not implemented
> - *           actions.
> + * @instructions: An array of instruction lists indexed by an action number from
> + *                the WDAT table. There can be %NULL entries for not implemented
> + *                actions.
>   */
>  struct wdat_wdt {
>  	struct platform_device *pdev;
>