linux-kernel - Re: [PATCH] of/address: Fix of_node memory leak in of_dma_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Nov 2020 13:07:47 -0600
From:   Rob Herring <robh@...nel.org>
To:     Evan Nimmo <evan.nimmo@...iedtelesis.co.nz>
Cc:     linux-kernel@...r.kernel.org, frowand.list@...il.com,
        robh+dt@...nel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] of/address: Fix of_node memory leak in of_dma_is_coherent

On Tue, 10 Nov 2020 15:28:25 +1300, Evan Nimmo wrote:
> Commit dabf6b36b83a ("of: Add OF_DMA_DEFAULT_COHERENT & select it on
> powerpc") added a check to of_dma_is_coherent which returns early
> if OF_DMA_DEFAULT_COHERENT is enabled. This results in the of_node_put()
> being skipped causing a memory leak. Moved the of_node_get() below this
> check so we now we only get the node if OF_DMA_DEFAULT_COHERENT is not
> enabled.
> 
> Fixes: dabf6b36b83a ("of: Add OF_DMA_DEFAULT_COHERENT & select it on
> powerpc")
> 
> Signed-off-by: Evan Nimmo <evan.nimmo@...iedtelesis.co.nz>
> ---
>  drivers/of/address.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Applied, thanks!