linux-kernel - Re: [PATCH][next] mptcp: fix a dereference of pointer before msk is null checked.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Nov 2020 19:23:57 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     Matthieu Baerts <matthieu.baerts@...sares.net>,
        "David S . Miller" <davem@...emloft.net>,
        Geliang Tang <geliangtang@...il.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        mptcp@...ts.01.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] mptcp: fix a dereference of pointer before msk is
 null checked.

On 11/11/2020 18:49, Mat Martineau wrote:
> On Mon, 9 Nov 2020, Colin King wrote:
> 
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> Currently the assignment of pointer net from the sock_net(sk) call
>> is potentially dereferencing a null pointer sk. sk points to the
>> same location as pointer msk and msk is being null checked after
>> the sock_net call.  Fix this by calling sock_net after the null
>> check on pointer msk.
>>
>> Addresses-Coverity: ("Dereference before null check")
>> Fixes: 00cfd77b9063 ("mptcp: retransmit ADD_ADDR when timeout")
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>> ---
>> net/mptcp/pm_netlink.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
> 
> Hi Colin and Jakub -
> 
> I noticed that the follow-up discussion on this patch didn't go to the
> netdev list, so patchwork did not get updated.
> 
> This patch is superseded by the following, which already has a
> Reviewed-by tag from Matthieu:
> 
> http://patchwork.ozlabs.org/project/netdev/patch/078a2ef5bdc4e3b2c25ef852461692001f426495.1604976945.git.geliangtang@gmail.com/
> 
> 
OK, thanks for letting me know. Good to see it got fixed!

Colin
> 
> Thanks!
> 
> -- 
> Mat Martineau
> Intel