lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2020 14:20:05 -0800 From: Adit Ranadive <aditr@...are.com> To: Qinglang Miao <miaoqinglang@...wei.com>, VMware PV-Drivers <pv-drivers@...are.com>, Doug Ledford <dledford@...hat.com>, Jason Gunthorpe <jgg@...pe.ca> Cc: linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] RDMA/pvrdma: fix missing kfree in pvrdma_register_device On 11/10/20 7:22 PM, Qinglang Miao wrote: > Fix missing kfree in pvrdma_register_device() when fails > to do ib_device_set_netdev. > > Fixes: 4b38da75e089 ("RDMA/drivers: Convert easy drivers to use ib_device_set_netdev()") > Reported-by: Hulk Robot <hulkci@...wei.com> > Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com> > --- > drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c > index fa2a3fa0c3e4..f71d99946bed 100644 > --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c > +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c > @@ -266,7 +266,7 @@ static int pvrdma_register_device(struct pvrdma_dev *dev) > } > ret = ib_device_set_netdev(&dev->ib_dev, dev->netdev, 1); > if (ret) > - return ret; > + goto err_qp_free; Thanks. This should be 'goto err_srq_free'. > spin_lock_init(&dev->srq_tbl_lock); > rdma_set_device_sysfs_group(&dev->ib_dev, &pvrdma_attr_group); > >
Powered by blists - more mailing lists