lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2020 11:21:59 +0800 From: Qinglang Miao <miaoqinglang@...wei.com> To: Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com> CC: <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Qinglang Miao" <miaoqinglang@...wei.com> Subject: [PATCH] leds: lp50xx: add missing fwnode_handle_put in error handling case Fix to goto child_out to do fwnode_handle_put(child) from the error handling case rather than simply return, as done elsewhere in this function. Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver") Reported-by: Hulk Robot <hulkci@...wei.com> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com> --- drivers/leds/leds-lp50xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c index 5fb4f24aeb2e..49a997b2c781 100644 --- a/drivers/leds/leds-lp50xx.c +++ b/drivers/leds/leds-lp50xx.c @@ -488,7 +488,7 @@ static int lp50xx_probe_dt(struct lp50xx *priv) mc_led_info = devm_kcalloc(priv->dev, LP50XX_LEDS_PER_MODULE, sizeof(*mc_led_info), GFP_KERNEL); if (!mc_led_info) - return -ENOMEM; + goto child_out; fwnode_for_each_child_node(child, led_node) { ret = fwnode_property_read_u32(led_node, "color", -- 2.23.0
Powered by blists - more mailing lists