linux-kernel - Re: [PATCH 19/25] soc: qcom: smp2p: Remove unused struct attribute provide another

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201111052038.GG173948@builder.lan>
Date:   Tue, 10 Nov 2020 23:20:38 -0600
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Andy Gross <agross@...nel.org>, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 19/25] soc: qcom: smp2p: Remove unused struct attribute
 provide another

On Tue 03 Nov 09:28 CST 2020, Lee Jones wrote:

> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/soc/qcom/smp2p.c:74: warning: Function parameter or member 'flags' not described in 'smp2p_smem_item'
>  drivers/soc/qcom/smp2p.c:149: warning: Function parameter or member 'out' not described in 'qcom_smp2p'
> 
> Cc: Andy Gross <agross@...nel.org>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: linux-arm-msm@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/soc/qcom/smp2p.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c
> index a9709aae54abb..43df63419c327 100644
> --- a/drivers/soc/qcom/smp2p.c
> +++ b/drivers/soc/qcom/smp2p.c
> @@ -52,7 +52,6 @@
>   * @remote_pid:		processor id of receiving end
>   * @total_entries:	number of entries - always SMP2P_MAX_ENTRY
>   * @valid_entries:	number of allocated entries
> - * @flags:
>   * @entries:		individual communication entries
>   *     @name:		name of the entry
>   *     @value:		content of the entry
> @@ -65,7 +64,6 @@ struct smp2p_smem_item {
>  	u16 remote_pid;
>  	u16 total_entries;
>  	u16 valid_entries;
> -	u32 flags;

This struct describes the data shared between processors in the SoC and
as such these 32 bits are significant. I believe we have an incoming
patch that adds handling of some flag, so let's document it properly
at that time.

I've applied the second half of the patch for now.

Regards,
Bjorn

>  
>  	struct {
>  		u8 name[SMP2P_MAX_ENTRY_NAME];
> @@ -112,6 +110,7 @@ struct smp2p_entry {
>   * struct qcom_smp2p - device driver context
>   * @dev:	device driver handle
>   * @in:		pointer to the inbound smem item
> + * @out:	pointer to the outbound smem item
>   * @smem_items:	ids of the two smem items
>   * @valid_entries: already scanned inbound entries
>   * @local_pid:	processor id of the inbound edge
> -- 
> 2.25.1
>