linux-kernel - Re: [PATCH v3] reboot: allow to specify reboot mode via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Nov 2020 10:22:39 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Matteo Croce <mcroce@...ux.microsoft.com>
Cc:     linux-kernel@...r.kernel.org, Mike Rapoport <rppt@...nel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Arnd Bergmann <arnd@...db.de>,
        Pavel Tatashin <pasha.tatashin@...een.com>,
        Kees Cook <keescook@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Tyler Hicks <tyhicks@...ux.microsoft.com>
Subject: Re: [PATCH v3] reboot: allow to specify reboot mode via sysfs

On Tue 2020-11-10 18:36:05, Matteo Croce wrote:
> On Tue, Nov 10, 2020 at 3:58 PM Petr Mladek <pmladek@...e.com> wrote:
> > On Mon 2020-11-09 17:45:38, Matteo Croce wrote:
> > > From: Matteo Croce <mcroce@...rosoft.com>
> > > +What:                /sys/kernel/reboot/force
> > > +Date:                November 2020
> > > +KernelVersion:       5.11
> > > +Contact:     Matteo Croce <mcroce@...rosoft.com>
> > > +Description: Force an immediate reboot.
> >
> > This makes me feel like that the kernel will reboot
> > immediately when you write "1". It would deserve a better
> > explanation that would make it clear, something like:
> >
> > Description:    Use forced reboot that does not contact the init system.
> >
> 
> Description: Don't wait for any other CPUs on reboot and avoid
> anything that could hang.

Sound good to me. I see that Andrew already queued the updated patch
with my Reviewed-by so all is OK.

Best Regards,
Petr