[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 11 Nov 2020 01:34:11 -0800
From: John Fastabend <john.fastabend@...il.com>
To: Andrii Nakryiko <andrii.nakryiko@...il.com>, xiakaixu1987@...il.com
Cc: Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Martin Lau <kafai@...com>, Song Liu <songliubraving@...com>,
Yonghong Song <yhs@...com>,
Andrii Nakryiko <andrii@...nel.org>,
john fastabend <john.fastabend@...il.com>,
KP Singh <kpsingh@...omium.org>,
Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>,
Kaixu Xia <kaixuxia@...cent.com>
Subject: Re: [PATCH v3] bpf: Fix unsigned 'datasec_id' compared with zero in
check_pseudo_btf_id
Andrii Nakryiko wrote:
> On Tue, Nov 10, 2020 at 9:03 PM <xiakaixu1987@...il.com> wrote:
> >
> > From: Kaixu Xia <kaixuxia@...cent.com>
> >
> > The unsigned variable datasec_id is assigned a return value from the call
> > to check_pseudo_btf_id(), which may return negative error code.
> >
> > Fixes coccicheck warning:
> >
> > ./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expression compared with zero: datasec_id > 0
> >
> > Reported-by: Tosk Robot <tencent_os_robot@...cent.com>
> > Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>
> > ---
>
> Looks good.
>
> Acked-by: Andrii Nakryiko <andrii@...nel.org>
>
> [...]
Acked-by: John Fastabend <john.fastabend@...il.com>
Powered by blists - more mailing lists