lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2020 13:46:31 +0200 From: Jarkko Nikula <jarkko.nikula@...ux.intel.com> To: Vaibhav Gupta <vaibhavgupta40@...il.com> Cc: Ajay Gupta <ajayg@...dia.com>, Bjorn Helgaas <helgaas@...nel.org>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com> Subject: Re: [PATCH v1] i2c: nvidia-gpu: drop empty stub for runtime pm On 11/11/20 12:54 PM, Vaibhav Gupta wrote: > On Tue, Nov 10, 2020 at 02:33:43PM +0200, Jarkko Nikula wrote: >>>> +#define gpu_i2c_suspend NULL >> Perhaps we can put NULL directly into UNIVERSAL_DEV_PM_OPS() for the suspend >> callback? >> > Yes. I have noticed that the approach for this is random. Many drivers pass > NULL directly to the dev_pm_ops type variable, and rest of them use a macro. > > I used it for symmetry. I mean there is 'gpu_i2c_resume', so although a macro, > I have put a 'gpu_i2c_suspend'. > > Although it won't make any significant change, but if required, I can send > another patch where NULL is passed into UNIVERSAL_DEV_PM_OPS() instead. No need to resend from my side, it was just a remark and I gave already the reviewed-by tag. Jarkko
Powered by blists - more mailing lists