lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2020 13:36:43 +0100 From: Vlastimil Babka <vbabka@...e.cz> To: Alex Shi <alex.shi@...ux.alibaba.com>, akpm@...ux-foundation.org, mgorman@...hsingularity.net, tj@...nel.org, hughd@...gle.com, khlebnikov@...dex-team.ru, daniel.m.jordan@...cle.com, willy@...radead.org, hannes@...xchg.org, lkp@...el.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org, cgroups@...r.kernel.org, shakeelb@...gle.com, iamjoonsoo.kim@....com, richard.weiyang@...il.com, kirill@...temov.name, alexander.duyck@...il.com, rong.a.chen@...el.com, mhocko@...e.com, vdavydov.dev@...il.com, shy828301@...il.com Subject: Re: [PATCH v21 05/19] mm/vmscan: remove unnecessary lruvec adding On 11/5/20 9:55 AM, Alex Shi wrote: > We don't have to add a freeable page into lru and then remove from it. > This change saves a couple of actions and makes the moving more clear. > > The SetPageLRU needs to be kept before put_page_testzero for list > integrity, otherwise: > > #0 move_pages_to_lru #1 release_pages > if !put_page_testzero > if (put_page_testzero()) > !PageLRU //skip lru_lock > SetPageLRU() > list_add(&page->lru,) > list_add(&page->lru,) > > [akpm@...ux-foundation.org: coding style fixes] > Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com> > Acked-by: Hugh Dickins <hughd@...gle.com> > Acked-by: Johannes Weiner <hannes@...xchg.org> > Cc: Andrew Morton <akpm@...ux-foundation.org> > Cc: Johannes Weiner <hannes@...xchg.org> > Cc: Tejun Heo <tj@...nel.org> > Cc: Matthew Wilcox <willy@...radead.org> > Cc: Hugh Dickins <hughd@...gle.com> > Cc: linux-mm@...ck.org > Cc: linux-kernel@...r.kernel.org Acked-by: Vlastimil Babka <vbabka@...e.cz> Nice cleanup!
Powered by blists - more mailing lists