[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 11 Nov 2020 14:23:48 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Rob Herring <robh+dt@...nel.org>,
Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Wolfgang Grandegger <wg@...ndegger.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Sascha Hauer <kernel@...gutronix.de>,
linux-can@...r.kernel.org, netdev <netdev@...r.kernel.org>,
devicetree@...r.kernel.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Joakim Zhang <qiangqing.zhang@....com>
Subject: Re: [PATCH v3 2/2] dt-bindings: can: flexcan: convert fsl,*flexcan
bindings to yaml
On 11/10/20 4:43 PM, Rob Herring wrote:
> On Thu, Oct 22, 2020 at 2:52 AM Oleksij Rempel <o.rempel@...gutronix.de> wrote:
>>
>> In order to automate the verification of DT nodes convert
>> fsl-flexcan.txt to fsl,flexcan.yaml
>>
>> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
>> Link: https://lore.kernel.org/r/20201016073315.16232-3-o.rempel@pengutronix.de
>> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
>> ---
>> .../bindings/net/can/fsl,flexcan.yaml | 135 ++++++++++++++++++
>> .../bindings/net/can/fsl-flexcan.txt | 57 --------
>> 2 files changed, 135 insertions(+), 57 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
>> delete mode 100644 Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
>
> Why did this go into v5.10-rc3? It's not a fix and now a fix is needed:
Sorry, this was against the rules and not a good idea.
> /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/clock/imx5-clock.example.dt.yaml:
> can@...c8000: compatible: 'oneOf' conditional failed, one must be
> fixed:
> ['fsl,imx53-flexcan', 'fsl,p1010-flexcan'] is too long
> Additional items are not allowed ('fsl,p1010-flexcan' was unexpected)
> 'fsl,imx53-flexcan' is not one of ['fsl,imx7d-flexcan',
> 'fsl,imx6ul-flexcan', 'fsl,imx6sx-flexcan']
> 'fsl,imx53-flexcan' is not one of ['fsl,ls1028ar1-flexcan']
> 'fsl,imx6q-flexcan' was expected
> 'fsl,lx2160ar1-flexcan' was expected
> From schema: /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/net/can/fsl,flexcan.example.dt.yaml:
> can@...0000: fsl,stop-mode: [[4294967295, 52, 28]] is too short
> From schema: /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
I've both issues and found two more. See the following thread for details:
http://lore.kernel.org/r/20201111130507.1560881-1-mkl@pengutronix.de
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists