linux-kernel - RE: [PATCH 4/8] usb: typec: Remove one bit support for the Thunderbolt rounded/non-rounded cable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Nov 2020 01:38:44 +0000
From:   "Patel, Utkarsh H" <utkarsh.h.patel@...el.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "pmalani@...omium.org" <pmalani@...omium.org>,
        "enric.balletbo@...labora.com" <enric.balletbo@...labora.com>,
        "Mani, Rajmohan" <rajmohan.mani@...el.com>,
        "Shaikh, Azhar" <azhar.shaikh@...el.com>
Subject: RE: [PATCH 4/8] usb: typec: Remove one bit support for the
 Thunderbolt rounded/non-rounded cable

Hi Heikki,

> -----Original Message-----
> From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Sent: Tuesday, November 10, 2020 4:20 AM
> To: Patel, Utkarsh H <utkarsh.h.patel@...el.com>
> Cc: linux-kernel@...r.kernel.org; linux-usb@...r.kernel.org;
> pmalani@...omium.org; enric.balletbo@...labora.com; Mani, Rajmohan
> <rajmohan.mani@...el.com>; Shaikh, Azhar <azhar.shaikh@...el.com>
> Subject: Re: [PATCH 4/8] usb: typec: Remove one bit support for the
> Thunderbolt rounded/non-rounded cable
> 
> On Mon, Nov 09, 2020 at 04:37:12PM -0800, Utkarsh Patel wrote:
> > Two bits support for the Thunderbolt rounded/non-rounded cable has
> > been added to the header file.
> > Hence, removing unused TBT_CABLE_ROUNDED definition from the header
> file.
> >
> > Fixes: ca469c292edc ("usb: typec: Add definitions for Thunderbolt 3
> > Alternate Mode")
> 
> And again?

Ack. I will remove the fix tag in v2.

> 
> > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@...el.com>
> > ---
> >  include/linux/usb/typec_tbt.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/include/linux/usb/typec_tbt.h
> > b/include/linux/usb/typec_tbt.h index aad648d14bb3..63dd44b72e0c
> > 100644
> > --- a/include/linux/usb/typec_tbt.h
> > +++ b/include/linux/usb/typec_tbt.h
> > @@ -39,7 +39,6 @@ struct typec_thunderbolt_data {
> >  #define   TBT_CABLE_USB3_GEN1		1
> >  #define   TBT_CABLE_USB3_PASSIVE	2
> >  #define   TBT_CABLE_10_AND_20GBPS	3
> > -#define TBT_CABLE_ROUNDED		BIT(19)
> >  #define TBT_CABLE_ROUNDED_SUPPORT(_vdo_) \
> >  					(((_vdo_) & GENMASK(20, 19)) >> 19)
> >  #define   TBT_GEN3_NON_ROUNDED                 0
> 
> thanks,
> 
> --
> Heikki

Sincerely,
Utkarsh Patel.