linux-kernel - Re: [PATCH 4.19 48/71] of: Fix reserved-memory overlap detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Nov 2020 15:34:44 +0100
From:   Vincent Whitchurch <vincent.whitchurch@...s.com>
To:     Pavel Machek <pavel@....cz>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>,
        Rob Herring <robh@...nel.org>, Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 48/71] of: Fix reserved-memory overlap detection

On Wed, Nov 11, 2020 at 01:53:59PM +0100, Pavel Machek wrote:
> >  OF: reserved mem: OVERLAP DETECTED!
> >  bar@0 (0x00000000--0x00001000) overlaps with foo@0 (0x00000000--0x00002000)
> >  OF: reserved mem: OVERLAP DETECTED!
> >  foo@0 (0x00000000--0x00002000) overlaps with baz@...0 (0x00001000--0x00002000)
> 
> Is it good idea to push this into 4.19 so early? It does not fix
> anything, it just causes warnings.
> 
> Such overlap currently exists in 4.19:
> 
> arch/arm/boot/dts/s5pv210.dtsi and can not be fixed easily, see:
> 
> > > > > >               clocks: clock-controller@...00000 {
> > > > > > +                     compatible = "samsung,s5pv210-clock";
> > > > > >                       reg = <0xe0100000 0x10000>;
> > > > > ...
> > > > > > +             pmu_syscon: syscon@...08000 {
> > > > > > +                     reg = <0xe0108000 0x8000>;
> > > > > >               };

The patch only concerns detection of overlaps in reserved-memory nodes,
and the above does not look like reserved-memory so it will not be
affected.

That being said, I already questioned the need for backporting this
patch:

 https://lore.kernel.org/lkml/20201103111110.lvapcdf4nndunsie@axis.com/