linux-kernel - Re: [PATCH] pinctrl: pinctrl-at91-pio4: Set irq handler and data in one go

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYyAvDzZ5fqtcYWxhdLU+JS00iKbo3pogG0AnvWv4-ucQ@mail.gmail.com>
Date:   Wed, 11 Nov 2020 15:53:04 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Nicolas Ferre <nicolas.ferre@...rochip.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Martin Kaiser <martin@...ser.cx>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: pinctrl-at91-pio4: Set irq handler and data in
 one go

On Tue, Nov 10, 2020 at 10:08 AM Nicolas Ferre
<nicolas.ferre@...rochip.com> wrote:
> On 09/11/2020 at 12:26, Andy Shevchenko wrote:
> > On Sun, Nov 8, 2020 at 8:05 PM Martin Kaiser <martin@...ser.cx> wrote:
> >>
> >> Replace the two separate calls for setting the irq handler and data with a
> >> single irq_set_chained_handler_and_data() call.
> >
> > Can it be rewritten to use the GPIO core facility of instantiating IRQ chip?
>
> I have the feeling it's out of scope for this (tiny) patch.

True, but a good suggestion anyways.

If you have a TODO for the AT91 pin controllers I think both using
the GPIOLIB_IRQCHIP can cut down
the code in these files quite a bit, and probably fix some unknown bugs.

Yours,
Linus Walleij