linux-kernel - Re: [PATCH] ttyprintk: optimize tpk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X61uGxi32JqMsGWl@kroah.com>
Date:   Thu, 12 Nov 2020 18:17:15 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     sunjunyong <sunjy516@...il.com>
Cc:     arnd@...db.de, sunjunyong@...omi.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ttyprintk: optimize tpk_close flush code

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Nov 12, 2020 at 09:41:22PM +0800, sunjunyong wrote:
> Hi Greg:
> It have no logic that handles NULL in tpk_flush() but tpk_printk().

Sorry, yes, that is what I mean.

> Do you mean that if i understand correctly?!I think we should not remove 
> the logic that handles NULL in tpk_printk() as we don't know if the buf 
> from parent caller is null or not.

Yes you do, you control that buffer right?  This is a static function,
you know what is happening here.

> But we transfer a null buf to tpk_printk()
>  for previous version of tpk_close, i think it's redundant.
> 
> The comment is a hitory tip for other guys to understand.I suggest to 
> keep it as before if you like.

The call to flush makes it obvious, no need to keep it.  And we have git
history for people to look at if they are curious about past versions.

thanks,

greg k-h