linux-kernel - Re: [PATCH v3 07/11] input: raspberrypi-ts: Release firmware handle when not needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9e3a04f0ae76675f610bf25e6b53b4aff26afae4.camel@suse.de>
Date:   Thu, 12 Nov 2020 10:06:21 +0100
From:   Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     u.kleine-koenig@...gutronix.de, linux-kernel@...r.kernel.org,
        f.fainelli@...il.com, linux-pwm@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        wahrenst@....net, linux-input@...r.kernel.org,
        gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        p.zabel@...gutronix.de, linux-gpio@...r.kernel.org,
        linus.walleij@...aro.org, linux-clk@...r.kernel.org,
        sboyd@...nel.org, linux-rpi-kernel@...ts.infradead.org,
        bgolaszewski@...libre.com, andy.shevchenko@...il.com
Subject: Re: [PATCH v3 07/11] input: raspberrypi-ts: Release firmware handle
 when not needed

On Wed, 2020-11-11 at 17:45 -0800, Dmitry Torokhov wrote:
> Hi Nicolas,
> 
> On Wed, Nov 04, 2020 at 11:39:33AM +0100, Nicolas Saenz Julienne wrote:
> > Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
> > interface when unbinding the device.
> 
> Unless I am mistaken this driver does not really need the firmware
> structure past rpi_ts_probe(), and will be fine if it disappears earlier
> than unbind time.

Yes, I missed that. Will update it.

Regards,
Nicolas


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)