linux-kernel - RE: [for-next][PATCH 12/17] fgraph: Make overruns 4 bytes in graph stack structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aabe0dd1fd7b46aaaadb2b34912b6718@AcuMS.aculab.com>
Date:   Thu, 12 Nov 2020 09:18:21 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Steven Rostedt' <rostedt@...dmis.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: RE: [for-next][PATCH 12/17] fgraph: Make overruns 4 bytes in graph
 stack structure

From: Steven Rostedt
> Sent: 12 November 2020 00:33
> 
> Inspecting the data structures of the function graph tracer, I found that
> the overrun value is unsigned long, which is 8 bytes on a 64 bit machine,
> and not only that, the depth is an int (4 bytes). The overrun can be simply
> an unsigned int (4 bytes) and pack the ftrace_graph_ret structure better.
> 
> The depth is moved up next to the func, as it is used more often with func,
> and improves cache locality.
...
>  } __packed;

Does this many any/much difference given that the structure is
marked __packed?

OTOH the __packed will (probably) kill performance on systems
that don't support mis-aligned accesses.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)