linux-kernel - Re: [PATCH] arm64: dts: allwinner: a64: fix sid node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201112095422.in6s5ctgv7in35on@gilmour.lan>
Date:   Thu, 12 Nov 2020 10:54:22 +0100
From:   Maxime Ripard <maxime@...no.tech>
To:     Frank Lee <frank@...winnertech.com>
Cc:     robh+dt@...nel.org, wens@...e.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        tiny.windzz@...il.com
Subject: Re: [PATCH] arm64: dts: allwinner: a64: fix sid node name

Hi,

On Mon, Nov 09, 2020 at 08:21:01PM +0800, Frank Lee wrote:
> From: Yangtao Li <frank@...winnertech.com>
> 
> Sid should be an efuse type device accurately. And no one
> needs sid label, so delete it.
> 
> Signed-off-by: Yangtao Li <frank@...winnertech.com>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index dc238814013c..96543df5d890 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -520,7 +520,7 @@ mmc2: mmc@...1000 {
>  			#size-cells = <0>;
>  		};
>  
> -		sid: eeprom@...4000 {
> +		efuse@...4000 {
>  			compatible = "allwinner,sun50i-a64-sid";
>  			reg = <0x1c14000 0x400>;
>  			#address-cells = <1>;

I agree with this on principle, but we should do it on all the SoCs at
once. Can you send another version doing so?

Thanks!
Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)