linux-kernel - Re: [PATCH net] net: ethernet: mtk-star-emac: fix error return code in mtk_star

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Nov 2020 12:41:26 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Zhang Changzhong <zhangchangzhong@...wei.com>
Cc:     nbd@....name, John Crispin <john@...ozen.org>,
        Sean Wang <sean.wang@...iatek.com>,
        Mark Lee <Mark-MC.Lee@...iatek.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: ethernet: mtk-star-emac: fix error return code
 in mtk_star_enable()

On Thu, Nov 12, 2020 at 12:33 PM Zhang Changzhong
<zhangchangzhong@...wei.com> wrote:
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>
> ---
>  drivers/net/ethernet/mediatek/mtk_star_emac.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> index 1325055..2ebacb6 100644
> --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
> +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> @@ -966,6 +966,7 @@ static int mtk_star_enable(struct net_device *ndev)
>                                       mtk_star_adjust_link, 0, priv->phy_intf);
>         if (!priv->phydev) {
>                 netdev_err(ndev, "failed to connect to PHY\n");
> +               ret = -ENODEV;
>                 goto err_free_irq;
>         }
>
> --
> 2.9.5
>

Acked-by: Bartosz Golaszewski <bgolaszewski@...libre.com>