linux-kernel - RE: [PATCH 05/15] input: touchscreen: imx6ul_tsc: Remove set but unused variable 'value'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB529451BA4FB237FA6C811E0790E70@VI1PR04MB5294.eurprd04.prod.outlook.com>
Date:   Thu, 12 Nov 2020 12:20:31 +0000
From:   Bough Chen <haibo.chen@....com>
To:     Lee Jones <lee.jones@...aro.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        Haibo Chen <haibo.chen@...escale.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
Subject: RE: [PATCH 05/15] input: touchscreen: imx6ul_tsc: Remove set but
 unused variable 'value'

> -----Original Message-----
> From: Lee Jones [mailto:lee.jones@...aro.org]
> Sent: 2020年11月12日 19:02
> To: lee.jones@...aro.org
> Cc: linux-kernel@...r.kernel.org; Dmitry Torokhov
> <dmitry.torokhov@...il.com>; Shawn Guo <shawnguo@...nel.org>; Sascha
> Hauer <s.hauer@...gutronix.de>; Pengutronix Kernel Team
> <kernel@...gutronix.de>; Fabio Estevam <festevam@...il.com>;
> dl-linux-imx <linux-imx@....com>; Haibo Chen <haibo.chen@...escale.com>;
> linux-input@...r.kernel.org
> Subject: [PATCH 05/15] input: touchscreen: imx6ul_tsc: Remove set but unused
> variable 'value'
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/input/touchscreen/imx6ul_tsc.c: In function ‘adc_irq_fn’:
>  drivers/input/touchscreen/imx6ul_tsc.c:307:6: warning: variable ‘value’ set
> but not used [-Wunused-but-set-variable]
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Shawn Guo <shawnguo@...nel.org>
> Cc: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: Pengutronix Kernel Team <kernel@...gutronix.de>
> Cc: Fabio Estevam <festevam@...il.com>
> Cc: NXP Linux Team <linux-imx@....com>
> Cc: Haibo Chen <haibo.chen@...escale.com>
> Cc: linux-input@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/input/touchscreen/imx6ul_tsc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/imx6ul_tsc.c
> b/drivers/input/touchscreen/imx6ul_tsc.c
> index cd369f9ac5e60..e1852f7d4d31e 100644
> --- a/drivers/input/touchscreen/imx6ul_tsc.c
> +++ b/drivers/input/touchscreen/imx6ul_tsc.c
> @@ -304,11 +304,10 @@ static irqreturn_t adc_irq_fn(int irq, void *dev_id)
> {
>  	struct imx6ul_tsc *tsc = dev_id;
>  	u32 coco;
> -	u32 value;
> 
>  	coco = readl(tsc->adc_regs + REG_ADC_HS);
>  	if (coco & 0x01) {
> -		value = readl(tsc->adc_regs + REG_ADC_R0);
> +		readl(tsc->adc_regs + REG_ADC_R0);
>  		complete(&tsc->completion);
>  	}
> 

Reviewed-by: Haibo Chen <haibo.chen@....com>

> --
> 2.25.1