linux-kernel - Re: [PATCH] reset: Add reset controller API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d12962a5-edba-869e-9383-5717dbffae0b@baylibre.com>
Date:   Thu, 12 Nov 2020 14:14:46 +0100
From:   Amjad Ouled-Ameur <aouledameur@...libre.com>
To:     Kevin Hilman <khilman@...libre.com>,
        Philipp Zabel <p.zabel@...gutronix.de>
Cc:     linux-kernel@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-usb@...r.kernel.org, Jerome Brunet <jbrunet@...libre.com>
Subject: Re: [PATCH] reset: Add reset controller API

On 03/10/2020 01:00, Kevin Hilman wrote:
> Amjad Ouled-Ameur <aouledameur@...libre.com> writes:
>
>> The current reset framework API does not allow to release what is done by
>> reset_control_reset(), IOW decrement triggered_count. Add the new
>> reset_control_resettable() call to do so.
>>
>> When reset_control_reset() has been called once, the counter
>> triggered_count, in the reset framework, is incremented i.e the resource
>> under the reset is in-use and the reset should not be done again.
>> reset_control_resettable() would be the way to state that the resource is
>> no longer used and, that from the caller's perspective, the reset can be
>> fired again if necessary.
>>
>> This patch will fix a usb suspend warning seen on the libretech-cc
>> related to the shared reset line. This warning was addressed by the
>> previously reverted commit 7a410953d1fb ("usb: dwc3: meson-g12a: fix shared
>> reset control use")
> Could you also send a patch that shows how your new feature can be used
> to fix the problem that was originally fixed by that patch (and still
> exists, now that it was reverted.)
>
> Thanks,
>
> Kevin

Hello Kevin,


Will do soon !


Sincerely,

Amjad