lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2020 16:37:38 -0800 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Alexandru Ardelean <alexandru.ardelean@...log.com> Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/6] Input: adp5589: use a single variable for error in probe Hi Alexandru, On Wed, Nov 11, 2020 at 10:48:28AM +0200, Alexandru Ardelean wrote: > The 'error' & 'ret' variables are used. This is a bit of duplication. > This change replaces the use of error with the 'ret' variable since the > name is a bit more generic. I really prefer variables that carry error codes/success and are used in error paths to be called "error", and "ret" or "retval" to be used in cases where we may return actual data. Thanks. -- Dmitry
Powered by blists - more mailing lists