lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Nov 2020 08:48:32 +0800 From: tanhuazhong <tanhuazhong@...wei.com> To: Jakub Kicinski <kuba@...nel.org> CC: <davem@...emloft.net>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>, <linuxarm@...wei.com> Subject: Re: [PATCH V2 net-next 11/11] net: hns3: add debugfs support for interrupt coalesce On 2020/11/12 0:15, Jakub Kicinski wrote: > On Wed, 11 Nov 2020 11:16:37 +0800 tanhuazhong wrote: >> On 2020/11/11 9:28, Jakub Kicinski wrote: >>> On Mon, 9 Nov 2020 11:22:39 +0800 Huazhong Tan wrote: >>>> Since user may need to check the current configuration of the >>>> interrupt coalesce, so add debugfs support for query this info, >>>> which includes DIM profile, coalesce configuration of both software >>>> and hardware. >>>> >>>> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com> >>> >>> Please create a file per vector so that users can just read it instead >>> of dumping the info into the logs. >>> >> >> This patch should be removed from this series right now. Since this new >> read method needs some adaptations and verifications, and there maybe >> another better ways to dump this info. >> >>> Even better we should put as much of this information as possible into >>> the ethtool API. dim state is hardly hardware-specific. >>> >> >> Should the ethtool API used to dump the hardware info? Could you provide >> some hints to do it? > > Not necessarily hardware info but if there is a use case for inspecting > DIM state we can extend > > coalesce_fill_reply() in net/ethtool/coalesce.c > > to report it. > ok, thanks. > . >
Powered by blists - more mailing lists