linux-kernel - Re: [PATCH v3 03/12] mm/filemap: Add helper for finding pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201112142508.GA17076@casper.infradead.org>
Date:   Thu, 12 Nov 2020 14:25:08 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     linux-mm@...ck.org, linux-fsdevel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Hugh Dickins <hughd@...gle.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Yang Shi <yang.shi@...ux.alibaba.com>,
        Dave Chinner <dchinner@...hat.com>,
        linux-kernel@...r.kernel.org, Jan Kara <jack@...e.cz>,
        William Kucharski <william.kucharski@...cle.com>
Subject: Re: [PATCH v3 03/12] mm/filemap: Add helper for finding pages

On Tue, Oct 27, 2020 at 06:56:42PM +0000, Christoph Hellwig wrote:
> > +static inline struct page *xas_find_get_entry(struct xa_state *xas,
> > +		pgoff_t max, xa_mark_t mark)
> 
> I'd expect the xas_ prefix for function from xarray.h.  Maybe this
> wants a better name?

The obvious name for this is find_get_entry().  But that already exists.
Although it turns out it has only two users and one of them doesn't
actually want to use it, so I'm going to rename find_get_entry() to
mapping_get_entry() and then this can become find_get_entry().