linux-kernel - [PATCH] loop: Fix passing zero to 'PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 12 Nov 2020 22:52:33 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <axboe@...nel.dk>, <maco@...roid.com>
CC:     <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        YueHaibing <yuehaibing@...wei.com>
Subject: [PATCH] loop: Fix passing zero to 'PTR_ERR' warning

Fix smatch warning:

drivers/block/loop.c:799 loop_attr_backing_file_show() warn: passing zero to 'PTR_ERR'

file_path() never returns 0, so use IS_ERR instead of
IS_ERR_OR_NULL to fix this.

Signed-off-by: YueHaibing <yuehaibing@...wei.com>
---
 drivers/block/loop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 83701c2ae3ca..65d392307c6a 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -795,7 +795,7 @@ static ssize_t loop_attr_backing_file_show(struct loop_device *lo, char *buf)
 		p = file_path(lo->lo_backing_file, buf, PAGE_SIZE - 1);
 	spin_unlock_irq(&lo->lo_lock);
 
-	if (IS_ERR_OR_NULL(p))
+	if (IS_ERR(p))
 		ret = PTR_ERR(p);
 	else {
 		ret = strlen(p);
-- 
2.17.1