linux-kernel - Re: [PATCH] gcov: remove support for GCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <122d1259-19d5-008d-d290-62e22f279ffe@linux.ibm.com>
Date:   Thu, 12 Nov 2020 16:04:07 +0100
From:   Peter Oberparleiter <oberpar@...ux.ibm.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     clang-built-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gcov: remove support for GCC < 4.9

On 11.11.2020 04:05, Nick Desaulniers wrote:
> Since
> commit 0bddd227f3dc ("Documentation: update for gcc 4.9 requirement")
> the minimum supported version of GCC is gcc-4.9. It's now safe to remove
> this code.
> 
> Similar to
> commit 10415533a906 ("gcov: Remove old GCC 3.4 support")
> but that was for GCC 4.8 and this is for GCC 4.9.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/427
> Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>

Looks good, thanks!

Reviewed-by: Peter Oberparleiter <oberpar@...ux.ibm.com>

Andrew, could you pick this up via your tree?

> ---
>  kernel/gcov/gcc_4_7.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
> index 53c67c87f141..0da0aacc1f26 100644
> --- a/kernel/gcov/gcc_4_7.c
> +++ b/kernel/gcov/gcc_4_7.c
> @@ -25,10 +25,8 @@
>  #define GCOV_COUNTERS			9
>  #elif (__GNUC__ > 5) || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1)
>  #define GCOV_COUNTERS			10
> -#elif __GNUC__ == 4 && __GNUC_MINOR__ >= 9
> -#define GCOV_COUNTERS			9
>  #else
> -#define GCOV_COUNTERS			8
> +#define GCOV_COUNTERS			9
>  #endif
>  
>  #define GCOV_TAG_FUNCTION_LENGTH	3
> 


-- 
Peter Oberparleiter
Linux on Z Development - IBM Germany