linux-kernel - Re: [PATCH][next] SFH: fix error return check for -ERESTARTSYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2011121626590.6877@cbobk.fhfr.pm>
Date:   Thu, 12 Nov 2020 16:27:11 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Colin King <colin.king@...onical.com>
cc:     Nehal Shah <nehal-bakulchandra.shah@....com>,
        Sandeep Singh <sandeep.singh@....com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] SFH: fix error return check for -ERESTARTSYS

On Fri, 30 Oct 2020, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently the check for the error return code -ERESTARTSYS is dead code
> and never executed because a previous check for ret < 0 is catching this
> and returning -ETIMEDOUT instead.  Fix this by checking for -ERESTARTSYS
> before the more generic negative error code.
> 
> Addresses-Coverity: ("Logically dead code")
> Fixes: 4b2c53d93a4b ("SFH:Transport Driver to add support of AMD Sensor Fusion Hub (SFH)")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs