lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Nov 2020 16:30:57 +0100 From: Vitaly Kuznetsov <vkuznets@...hat.com> To: Wei Liu <wei.liu@...nel.org>, Linux on Hyper-V List <linux-hyperv@...r.kernel.org> Cc: virtualization@...ts.linux-foundation.org, Linux Kernel List <linux-kernel@...r.kernel.org>, Michael Kelley <mikelley@...rosoft.com>, Vineeth Pillai <viremana@...ux.microsoft.com>, Sunil Muthuswamy <sunilmut@...rosoft.com>, Nuno Das Neves <nunodasneves@...ux.microsoft.com>, Wei Liu <wei.liu@...nel.org>, "K. Y. Srinivasan" <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Stephen Hemminger <sthemmin@...rosoft.com>, Daniel Lezcano <daniel.lezcano@...aro.org>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [PATCH v2 05/17] clocksource/hyperv: use MSR-based access if running as root Wei Liu <wei.liu@...nel.org> writes: > Signed-off-by: Wei Liu <wei.liu@...nel.org> In the missing commit message I'd like to see why we don't use 'TSC page' clocksource for the root partition. My guess would be that it's not available and actually we're supposed to use raw TSC value (because root partitions never migrate) but please spell it out. > --- > drivers/clocksource/hyperv_timer.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/clocksource/hyperv_timer.c b/drivers/clocksource/hyperv_timer.c > index ba04cb381cd3..269a691bd2c4 100644 > --- a/drivers/clocksource/hyperv_timer.c > +++ b/drivers/clocksource/hyperv_timer.c > @@ -426,6 +426,9 @@ static bool __init hv_init_tsc_clocksource(void) > if (!(ms_hyperv.features & HV_MSR_REFERENCE_TSC_AVAILABLE)) > return false; > > + if (hv_root_partition) > + return false; > + > hv_read_reference_counter = read_hv_clock_tsc; > phys_addr = virt_to_phys(hv_get_tsc_page()); -- Vitaly
Powered by blists - more mailing lists