linux-kernel - Re: [PATCH] clk: samsung: allow building the clkout driver as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201112161820.GA17700@kozik-lap>
Date:   Thu, 12 Nov 2020 17:18:20 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Sylwester Nawrocki <snawrocki@...nel.org>
Cc:     Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Tomasz Figa <tomasz.figa@...il.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        linux-samsung-soc@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] clk: samsung: allow building the clkout driver as module

On Thu, Nov 12, 2020 at 03:36:35PM +0100, Sylwester Nawrocki wrote:
> On 11/10/20 20:37, Krzysztof Kozlowski wrote:
> > The Exynos clock output driver can be built as module (it does not have
> > to be part of core init process) for better customization.  Adding a
> > KConfig entry allows also compile testing for build coverage.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> 
> This needs to go through your tree due to dependencies on your previous
> patches, so
> 
> Acked-by: Sylwester Nawrocki <s.nawrocki@...sung.com>

Yes, thanks.

> 
> > ---
> >   drivers/clk/samsung/Kconfig             | 10 ++++++++++
> >   drivers/clk/samsung/Makefile            |  2 +-
> >   drivers/clk/samsung/clk-exynos-clkout.c |  1 +
> >   3 files changed, 12 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
> > index 57d4b3f20417..b6b2cb209543 100644
> > --- a/drivers/clk/samsung/Kconfig
> > +++ b/drivers/clk/samsung/Kconfig
> > @@ -19,6 +19,16 @@ config EXYNOS_AUDSS_CLK_CON
> >   	  on some Exynos SoC variants. Choose M or Y here if you want to
> >   	  use audio devices such as I2S, PCM, etc.
> >   
> > +config EXYNOS_CLK_OUT
> 
> Perhaps change it EXYNOS_CLKOUT for a better match with the SoC documentation? 

Sure, I applied it with name fixup.

Best regards,
Krzysztof