linux-kernel - Re: [GIT PULL] bootconfig: Extend the magic check range to the preceding 3 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201113130305.42284c27@oasis.local.home>
Date:   Fri, 13 Nov 2020 13:03:05 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Chen Yu <yu.chen.surf@...il.com>
Subject: Re: [GIT PULL] bootconfig: Extend the magic check range to the
 preceding 3 bytes

On Fri, 13 Nov 2020 09:57:54 -0800
Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Fri, Nov 13, 2020 at 9:54 AM Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> > The issue is that grub padded the end of the ramdisk after loading it
> > into memory. I'm not sure how the bootconfig tool can fix this. Perhaps
> > make sure the ram disk size is 4 bytes aligned?  
> 
> Exactly. Since - as far as I can tell - the _only_ thing that actually
> generates that BOOTCONFIG_MAGIC marker is the bootconfig tool, you
> control the vertical and the horizontal. No need for some "heuristic"
> and searching for things.
> 
> And then that thing needs to be documented, so that if somebody else
> starts generating BOOTCONFIG_MAGIC markers, we have a hard rule in
> place that "look, the bootconfig is always aligned".
> 
> Might as well align it more than 4 bytes while at it and make it even stricter.
> 

OK, yes I agree with this.

Masami, can you send a patch to fix the bootconfig tool to make sure
that when it appends to the initrd that it makes sure the file size is
aligned. Would 32 bytes be big enough for an alignment?

-- Steve