linux-kernel - Re: [PATCH 4.19 107/191] ARM: dts: s5pv210: move PMU node out of clock controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201113182621.GA7102@duo.ucw.cz>
Date:   Fri, 13 Nov 2020 19:26:21 +0100
From:   Pavel Machek <pavel@....cz>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Jonathan Bakker <xc-racer2@...e.ca>,
        Sasha Levin <sashal@...nel.org>,
        Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 4.19 107/191] ARM: dts: s5pv210: move PMU node out of
 clock controller

Hi!

> > > > I don't think this commit should be backported to stable. It is simple
> > > > dtbs_check - checking whether Devicetree source matches device tree
> > > > schema. Neither the schema nor the warning existed in v4.19. I think
> > > > dtbs_check fixes should not be backported, unless a real issue is
> > > > pointed out.
> > > 
> > > I agree with you about the backporting. Hopefully Greg drops the
> > > commit.
> > > 
> > > But the other issue is: should mainline be fixed so that ranges do not overlap?
> > 
> > Yes, it should be. This should fail on mapping resources...
> > 
> > I'll take a look, thanks for the report.
> 
> +Cc Paweł and Marek,
> 
> The IO memory mappings overlap unfortunately on purpose. Most of the
> clock driver registers are in the first range of 0x3000 but it also uses
> two registers at offset 0xe000.
> 
> The samsung-s5pv210-pmu is used only as a syscon by phy-s5pv210-usb2.c
> which wants to play with 0x680c.
> 
> The solution could be to split the mapping into two parts but I don't
> want to do this. I don't have the hardware so there is a chance I will
> break things.
> 
> However if Paweł, Jonathan or Marek want to improve it - patches are
> welcomed. :)

Okay, it would be nice to at least have a comment there.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)