linux-kernel - Re: [PATCH] ipv6: remove unused function ipv6_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201113183649.GA1436199@ubuntu-m3-large-x86>
Date:   Fri, 13 Nov 2020 11:36:49 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>, Tom Rix <trix@...hat.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        clang-built-linux@...glegroups.com,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipv6: remove unused function ipv6_skb_idev()

On Fri, Nov 13, 2020 at 02:50:12PM +0100, Lukas Bulwahn wrote:
> Commit bdb7cc643fc9 ("ipv6: Count interface receive statistics on the
> ingress netdev") removed all callees for ipv6_skb_idev(). Hence, since
> then, ipv6_skb_idev() is unused and make CC=clang W=1 warns:
> 
>   net/ipv6/exthdrs.c:909:33:
>     warning: unused function 'ipv6_skb_idev' [-Wunused-function]
> 
> So, remove this unused function and a -Wunused-function warning.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>

Reviewed-by: Nathan Chancellor <natechancellor@...il.com>

> ---
> Alexey, Hideaki-san, please ack.
> 
> David, Jakub, please pick this minor non-urgent clean-up patch.
> 
>  net/ipv6/exthdrs.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c
> index 374105e4394f..584d1b06eb90 100644
> --- a/net/ipv6/exthdrs.c
> +++ b/net/ipv6/exthdrs.c
> @@ -906,10 +906,6 @@ void ipv6_exthdrs_exit(void)
>  /*
>   * Note: we cannot rely on skb_dst(skb) before we assign it in ip6_route_input().
>   */
> -static inline struct inet6_dev *ipv6_skb_idev(struct sk_buff *skb)
> -{
> -	return skb_dst(skb) ? ip6_dst_idev(skb_dst(skb)) : __in6_dev_get(skb->dev);
> -}
>  
>  static inline struct net *ipv6_skb_net(struct sk_buff *skb)
>  {
> -- 
> 2.17.1
>