linux-kernel - Re: [PATCH 1/3] arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201113184020.drntugqsnj7dzsnh@ultimatum>
Date:   Fri, 13 Nov 2020 12:40:20 -0600
From:   Nishanth Menon <nm@...com>
To:     Sekhar Nori <nsekhar@...com>, Lokesh Vutla <lokeshvutla@...com>
CC:     Faiz Abbas <faiz_abbas@...com>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <t-kristo@...com>,
        <robh+dt@...nel.org>, Grygorii Strashko <grygorii.strashko@...com>
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-j7200-main: Add gpio nodes in
 main domain

On 23:59-20201113, Sekhar Nori wrote:
[..]
> > dtbs_check: we added:
> > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@...000/gpio@...000: Missing #address-cells in interrupt provider
> > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@...000/gpio@...000: Missing #address-cells in interrupt provider
> > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@...000/gpio@...000: Missing #address-cells in interrupt provider
> > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@...000/gpio@...000: Missing #address-cells in interrupt provider
> 
> Hmm, running dtbs_check, I did not really see this. These are all the
> warnings I see for TI platforms: https://pastebin.ubuntu.com/p/m2my62mjQq/

Here is the full list of checks I ran through with kernel_patch_verify
(docker)
	https://pastebin.ubuntu.com/p/tcnWw89CMD/

See lines 128 onwards for this series. kernel_patch_verify does'nt
complain on existing warnings, but just prints when there are additional
ones added in. Also make sure we have the right dtc as well
dtc 1.6.0 and dt_schema 2020.8.1 was used.

> 
> The tree I am testing is linux-next of 12th Nov + these three patches
> applied.
> 
> Also, #address-cells for interrupt provider being compulsory does not
> make full sense to me. Nothing in
> Documentation/devicetree/bindings/interrupt-controller/interrupts.txt or
> Documentation/devicetree/bindings/gpio/gpio-davinci.txt suggests that as
> well.
> 
> Existing GPIO nodes for AM654 or J721E does not have #address-cells as well.
> 
> Adding Grygorii as well, in case he knows more about this.


Yes - we need to have this conversation in the community :) I had
tagged this internally already during the 5.10 merge cycle that we
need to clean up the #address-cells warning and in some cases, maybe
the bindings are probably not accurate to attempt an enforcement.
I'd really like a conclusion on the topic as I recollect Lokesh and
Grygorii had a debate internally, but reached no conclusion, lets get
the wisdom of the community to help us here.

[1] https://github.com/nmenon/kernel_patch_verify/blob/master/kpv
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D