linux-kernel - Re: [PATCH 35/40] drm/msm/disp/mdp5/mdp5_kms: Make local functions 'mdp5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Nov 2020 11:46:40 -0800
From:   abhinavk@...eaurora.org
To:     Lee Jones <lee.jones@...aro.org>
Cc:     freedreno@...ts.freedesktop.org, David Airlie <airlied@...ux.ie>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Sean Paul <sean@...rly.run>
Subject: Re: [PATCH 35/40] drm/msm/disp/mdp5/mdp5_kms: Make local functions
 'mdp5_{en, dis}able()' static

On 2020-11-13 05:49, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:299:5: warning: no previous
> prototype for ‘mdp5_disable’ [-Wmissing-prototypes]
>  drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:319:5: warning: no previous
> prototype for ‘mdp5_enable’ [-Wmissing-prototypes]
> 
> Cc: Rob Clark <robdclark@...il.com>
> Cc: Sean Paul <sean@...rly.run>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: linux-arm-msm@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> Cc: freedreno@...ts.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
Reviewed-by: Abhinav Kumar <abhinavk@...eaurora.org>
> ---
>  drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> index b3eecf8694771..15aed45022bc8 100644
> --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> @@ -296,7 +296,7 @@ static const struct mdp_kms_funcs kms_funcs = {
>  	.set_irqmask         = mdp5_set_irqmask,
>  };
> 
> -int mdp5_disable(struct mdp5_kms *mdp5_kms)
> +static int mdp5_disable(struct mdp5_kms *mdp5_kms)
>  {
>  	DBG("");
> 
> @@ -316,7 +316,7 @@ int mdp5_disable(struct mdp5_kms *mdp5_kms)
>  	return 0;
>  }
> 
> -int mdp5_enable(struct mdp5_kms *mdp5_kms)
> +static int mdp5_enable(struct mdp5_kms *mdp5_kms)
>  {
>  	DBG("");