linux-kernel - Re: [PATCH 02/30] include: drm: drm_atomic: Artificially use 'crtc' to avoid 'not used' warning

Open Source and information security mailing list archives

Date:   Fri, 13 Nov 2020 21:49:59 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     Lee Jones <lee.jones@...aro.org>, David Airlie <airlied@...ux.ie>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 02/30] include: drm: drm_atomic: Artificially use 'crtc'
 to avoid 'not used' warning

On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote:
> Hi Lee,
> 
> On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote:
> > The precedent has already been set by other macros in the same file.
> > 
> > Fixes the following W=1 kernel build warning(s):
> > 
> >  drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ set but not used [-Wunused-but-set-variable]
> >  55 | struct drm_crtc *crtc;
> >  | ^~~~
> > 
> > Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
> > Cc: Maxime Ripard <mripard@...nel.org>
> > Cc: Thomas Zimmermann <tzimmermann@...e.de>
> > Cc: David Airlie <airlied@...ux.ie>
> > Cc: Daniel Vetter <daniel@...ll.ch>
> > Cc: Rob Clark <robdclark@...il.com>
> > Cc: dri-devel@...ts.freedesktop.org
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> 
> Also applied to drm-misc-next.
> This was the last patch from this batch I will process.
> The others are left for the maintainers to pick up.

btw for patches that maintainers don't pick up, the usual process is that
we give them 2 weeks, then just mass apply. Now you're producing a lot of
patches, too much for me to keep track, so please just ping me with a
resend for those that expired and I'll go through and pick them all up.

Cheers, Daniel

> 
> 	Sam
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives