linux-kernel - Re: [PATCH] drivers: rtc: retire RTC_DRV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Nov 2020 15:17:50 -0600
From:   Rob Herring <robh@...nel.org>
To:     Roman Kiryanov <rkir@...gle.com>
Cc:     Paul Walmsley <paul.walmsley@...ive.com>,
        Miodrag Dinic <miodrag.dinic@...s.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Lingfeng Yang <lfy@...gle.com>
Subject: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

On Fri, Nov 13, 2020 at 3:13 PM Roman Kiryanov <rkir@...gle.com> wrote:
>
> Hi Rob, thank you for looking into this.
>
> On Fri, Nov 13, 2020 at 1:07 PM Rob Herring <robh@...nel.org> wrote:
> >
> > On Fri, Nov 13, 2020 at 12:52:33PM -0800, rkir@...gle.com wrote:
> > > From: Roman Kiryanov <rkir@...gle.com>
> > >
> > > The only user of RTC_DRV_GOLDFISH is
> > > the MIPS flavor of Android Studio Emulator
> > > (goldfish) which should be also retired.
> > >
> > > Signed-off-by: Roman Kiryanov <rkir@...gle.com>
> > > ---
> > >  arch/riscv/Kconfig.socs    |   1 -
> > >  drivers/rtc/Kconfig        |  10 --
> > >  drivers/rtc/Makefile       |   1 -
> > >  drivers/rtc/rtc-goldfish.c | 216 -------------------------------------
> > >  4 files changed, 228 deletions(-)
> > >  delete mode 100644 drivers/rtc/rtc-goldfish.c
> >
> > What about the binding and MAINTAINERS?
>
> My bad, I will update those files too.

Though the binding is still used in arch/mips/generic/board-ranchu.c
and arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts. The
latter was just added recently, so maybe premature to remove things?

Rob