linux-kernel - Re: [PATCH] s5p-jpeg: hangle error condition in s5p_jpeg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8c9ea26-fc55-d65d-e2b3-734af8b97c95@gmail.com>
Date:   Fri, 13 Nov 2020 22:35:05 +0100
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Baskov Evgeiny <baskov@...ras.ru>,
        Andrzej Pietrasiewicz <andrzejtp2010@...il.com>
Cc:     Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH] s5p-jpeg: hangle error condition in s5p_jpeg_probe

Hi Evgeiny,

Thank you for the patch.

There is a typo in the subject: s/hangle/handle/

Otherwise:

Acked-by: Jacek Anaszewski <jacek.anaszewski@...il.com>


On 11/13/20 5:06 PM, Baskov Evgeiny wrote:
> If an error happens in jpeg_get_drv_data(), i.e. match fails,
> jpeg->variant field is NULL, so we cannot access it.
> 
> Consider device probe failed if jpeg->variant is NULL.


-- 
Best regards,
Jacek Anaszewski