linux-kernel - [PATCH] locking-selftest: add option to proceed through unexpected failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Nov 2020 16:00:48 -0700
From:   Jim Cromie <jim.cromie@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     Jim Cromie <jim.cromie@...il.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>
Subject: [PATCH] locking-selftest: add option to proceed through unexpected failures

Locking selftest is currently (v.5.10-rc3) seeing 14 unexpected failures.
Add option to not disable debug_locks, so as to let it reveal any
locking flaws in new unrelated work.

Signed-off-by: Jim Cromie <jim.cromie@...il.com>
---
 lib/locking-selftest.c | 21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c
index a899b3f0e2e5..87889bcf3232 100644
--- a/lib/locking-selftest.c
+++ b/lib/locking-selftest.c
@@ -41,6 +41,20 @@ static int __init setup_debug_locks_verbose(char *str)
 
 __setup("debug_locks_verbose=", setup_debug_locks_verbose);
 
+/*
+ * proceed thru debug fails, leave debugging enabled
+ */
+static unsigned int debug_locks_proceed;
+
+static int __init setup_debug_locks_proceed(char *str)
+{
+	get_option(&str, &debug_locks_proceed);
+
+	return 1;
+}
+
+__setup("debug_locks_proceed=", setup_debug_locks_proceed);
+
 #define FAILURE		0
 #define SUCCESS		1
 
@@ -2480,9 +2494,10 @@ void locking_selftest(void)
 
 	if (unexpected_testcase_failures) {
 		printk("-----------------------------------------------------------------\n");
-		debug_locks = 0;
-		printk("BUG: %3d unexpected failures (out of %3d) - debugging disabled! |\n",
-			unexpected_testcase_failures, testcase_total);
+		debug_locks = debug_locks_proceed;
+		printk("BUG: %3d unexpected failures (out of %3d) - debugging %s! |\n",
+		       unexpected_testcase_failures, testcase_total,
+		       (!debug_locks_proceed) ? "disabled" : "proceeding anyway");
 		printk("-----------------------------------------------------------------\n");
 	} else if (expected_testcase_failures && testcase_successes) {
 		printk("--------------------------------------------------------\n");
-- 
2.28.0