linux-kernel - Re: [PATCH v2 5/5] crypto: hisilicon/hpre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Nov 2020 14:57:25 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Meng Yu <yumeng18@...wei.com>
Cc:     davem@...emloft.net, linux-crypto@...r.kernel.org,
        xuzaibo@...wei.com, wangzhou1@...ilicon.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/5] crypto: hisilicon/hpre - add 'CURVE25519'
 algorithm

On Mon, Nov 02, 2020 at 10:31:05AM +0800, Meng Yu wrote:
> Enable 'CURVE25519' algorithm in 'Kunpeng 930'.
> 
> Signed-off-by: Meng Yu <yumeng18@...wei.com>
> Reviewed-by: Zaibo Xu <xuzaibo@...wei.com>
> Reported-by: kernel test robot <lkp@...el.com>
> ---
>  drivers/crypto/hisilicon/hpre/hpre.h        |   2 +
>  drivers/crypto/hisilicon/hpre/hpre_crypto.c | 387 +++++++++++++++++++++++++++-
>  2 files changed, 381 insertions(+), 8 deletions(-)

This is not sparse clean:

  CC [M]  drivers/crypto/hisilicon/sec2/sec_crypto.o
../drivers/crypto/hisilicon/hpre/hpre_crypto.c:2073:18: warning: invalid assignment: |=
../drivers/crypto/hisilicon/hpre/hpre_crypto.c:2073:18:    left side has type restricted __le32
../drivers/crypto/hisilicon/hpre/hpre_crypto.c:2073:18:    right side has type unsigned int
../drivers/crypto/hisilicon/hpre/hpre_crypto.c:2192:20: warning: restricted __le32 degrades to integer

Please fix and resubmit.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt