linux-kernel - Re: [PATCH] perf vendor events: Update Skylake client events to v50

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38be0597-7f93-0aa1-b4c5-3c7f23b74f13@linux.intel.com>
Date:   Fri, 13 Nov 2020 16:12:37 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        linux-kernel <Linux-kernel@...r.kernel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        "Liang, Kan" <kan.liang@...el.com>, yao.jin@...el.com,
        Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH] perf vendor events: Update Skylake client events to v50

Hi Andi, Ian,

On 11/6/2020 12:21 PM, Namhyung Kim wrote:
> On Fri, Nov 6, 2020 at 12:12 PM Jin, Yao <yao.jin@...ux.intel.com> wrote:
>>
>> Hi Namhyung,
>>
>> On 11/6/2020 11:00 AM, Namhyung Kim wrote:
>>> Hi,
>>>
>>> On Wed, Nov 04, 2020 at 09:51:02AM +0800, Jin Yao wrote:
>>>> - Update Skylake events to v50.
>>>> - Update Skylake JSON metrics from TMAM 4.0.
>>>> - Fix the issue in DRAM_Parallel_Reads
>>>> - Fix the perf test warning
>>>>
>>>> Before:
>>>>
>>>> root@...-ppc:~# perf stat -M DRAM_Parallel_Reads -- sleep 1
>>>> event syntax error: '{arb/event=0x80,umask=0x2/,arb/event=0x80,umask=0x2,thresh=1/}:W'
>>>>                        \___ unknown term 'thresh' for pmu 'uncore_arb'
>>>>
>>>> valid terms: event,edge,inv,umask,cmask,config,config1,config2,name,period,percore
>>>>
>>>> Initial error:
>>>> event syntax error: '..umask=0x2/,arb/event=0x80,umask=0x2,thresh=1/}:W'
>>>>                                     \___ Cannot find PMU `arb'. Missing kernel support?
>>>>
>>>> root@...-ppc:~# perf test metrics
>>>> 10: PMU events                                 :
>>>> 10.3: Parsing of PMU event table metrics               : Skip (some metrics failed)
>>>> 10.4: Parsing of PMU event table metrics with fake PMUs: Ok
>>>> 67: Parse and process metrics                  : Ok
>>>>
>>>> After:
>>>>
>>>> root@...-ppc:~# perf stat -M MEM_Parallel_Reads -- sleep 1
>>>>
>>>>    Performance counter stats for 'system wide':
>>>>
>>>>            4,951,646      arb/event=0x80,umask=0x2/ #    26.30 MEM_Parallel_Reads       (50.04%)
>>>>              188,251      arb/event=0x80,umask=0x2,cmask=1/                                     (49.96%)
>>>>
>>>>          1.000867010 seconds time elapsed
>>>>
>>>> root@...-ppc:~# perf test metrics
>>>> 10: PMU events                                 :
>>>> 10.3: Parsing of PMU event table metrics               : Ok
>>>> 10.4: Parsing of PMU event table metrics with fake PMUs: Ok
>>>> 67: Parse and process metrics                  : Ok
>>>>
>>>> Signed-off-by: Jin Yao <yao.jin@...ux.intel.com>
>>>
>>> It seems not applied to acme/perf/core cleanly.
>>>
>>> Thanks,
>>> Namhyung
>>>
>>
>> It seems the patch mail is truncated. :(
>>
>> I attach the patch file in the mail. Sorry for inconvenience.
> 
> I've checked it fixed the perf test on my laptop (skylake).
> 
> Tested-by: Namhyung Kim <namhyung@...nel.org>
> 
> Thanks,
> Namhyung
> 

Can I get ACK for this patch?

It's mainly for fixing the perf-test issue and MEM_Parallel_Reads issue.

Thanks
Jin Yao