linux-kernel - Re: [PATCH net] net: phy: mscc: remove non-MACSec compatible phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 13 Nov 2020 09:42:26 +0100
From:   Steen Hegelund <steen.hegelund@...rochip.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Antoine Tenart <atenart@...nel.org>,
        Bryan Whitehead <Bryan.Whitehead@...rochip.com>,
        Microchip UNG Driver List <UNGLinuxDriver@...rochip.com>,
        John Haechten <John.Haechten@...rochip.com>,
        Netdev List <netdev@...r.kernel.org>,
        Linux Kernel List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: phy: mscc: remove non-MACSec compatible phy

On 12.11.2020 14:28, Jakub Kicinski wrote:
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>On Thu, 12 Nov 2020 10:04:29 +0100 Steen Hegelund wrote:
>> Selecting VSC8575 as a MACSec PHY was not correct
>>
>> The relevant datasheet can be found here:
>>   - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575
>>
>> Fixes: 0a504e9e97886 ("net: phy: mscc: macsec initialization")
>> Signed-off-by: Steen Hegelund <steen.hegelund@...rochip.com>
>
>Fixes tag: Fixes: 0a504e9e97886 ("net: phy: mscc: macsec initialization")
>Has these problem(s):
>        - Subject does not match target commit subject
>          Just use
>                git log -1 --format='Fixes: %h ("%s")'
Hi Jacub,

Right, that sha was for a tree object, not a commit. I should have
checked that.
Thanks for the log command example.  That is really useful.

BR
Steen

---------------------------------------
Steen Hegelund
steen.hegelund@...rochip.com