linux-kernel - RE: [PATCH] brcmfmac: fix error return code in brcmf_cfg80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea4b55d801ed418f9b0430ddba559457@infineon.com>
Date:   Fri, 13 Nov 2020 08:45:50 +0000
From:   <Chi-Hsien.Lin@...ineon.com>
To:     <zhangchangzhong@...wei.com>, <arend.vanspriel@...adcom.com>,
        <franky.lin@...adcom.com>, <hante.meuleman@...adcom.com>,
        <Wright.Feng@...ineon.com>, <kvalo@...eaurora.org>,
        <davem@...emloft.net>, <kuba@...nel.org>,
        <Chung-Hsien.Hsu@...ineon.com>
CC:     <linux-wireless@...r.kernel.org>,
        <brcm80211-dev-list.pdl@...adcom.com>,
        <brcm80211-dev-list@...ress.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] brcmfmac: fix error return code in
 brcmf_cfg80211_connect()

> Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in th>
>
> Fixes: 3b1e0a7bdfee ("brcmfmac: add support for SAE authentication offload")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>
Reviewed-by: Chi-hsien Lin <chi-hsien.lin@...ineon.com>

> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadc>
> index a2dbbb9..0ee421f 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -2137,7 +2137,8 @@ brcmf_cfg80211_connect(struct wiphy *wiphy, struct net_device *ndev,
>               BRCMF_WSEC_MAX_PSK_LEN);
>     else if (profile->use_fwsup == BRCMF_PROFILE_FWSUP_SAE) {
>       /* clean up user-space RSNE */
> -             if (brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0)) {
> +             err = brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0);
> +             if (err) {
>                       bphy_err(drvr, "failed to clean up user-space RSNE\n");
>                       goto done;
> }
> --
> 2.9.5